Skip to content

sum-of-multiples: add parameters to exercise placeholder #644

Closed
Closed
sum-of-multiples: add parameters to exercise placeholder#644

Description

@ilya-khadykin
ilya-khadykin
opened on Oct 3, 2017

We would like you to help us add expected parameters in placeholder templates as described in #509 to make it easier for learners to start working on the exercise in question.

Feel free to ask any questions, we'll be glad to help!

Activity

  1. ilya-khadykin
    added
    beginner friendly
    good first patch
    hacktoberfest
    on Oct 3, 2017

  2. ackerleytng commented on Oct 9, 2017

    @ackerleytng
    ackerleytng
    on Oct 9, 2017
    Contributor

    Hi! This is my first pull request ever! I'm trying to understand how pull requests work...

    I've completed all the necessary edits and pushed to my sum-of-multiples-add-parameters branch at ackerleytng/python.

    Do I have to make another pull request after this push, or is this good enough?

  3. ilya-khadykin
    closed this as completedin e21297eon Oct 9, 2017

  4. ilya-khadykin commented on Oct 9, 2017

    @ilya-khadykin
    ilya-khadykin
    on Oct 9, 2017
    ContributorAuthor

    @ackerleytng no, it looks Ok. I merged it btw 😄

  5. ackerleytng commented on Oct 9, 2017

    @ackerleytng
    ackerleytng
    on Oct 9, 2017
    Contributor

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions