You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Function in templates should have parameters? #509
I feel better if I have the parameters in template (maybe because I'm used to it from other sites). When I've been solving first problem with input I didn't knew how I'm supposed to get input. I had to look in the tester script.
You can always rename it 😄
Maybe not names, just some strange placeholders, but something that tells me what my function gets as input. Something like inputString or array.
@M-a-Ge well its not fixed yet because I fixed just one exercise. But others templates are still without parameters. If you find this a good idea then all exercises should be modified.
I don't know where to write it to let others know that new exercises should have parameters in template and to tell contributors that someone could upgrade other exercises as well.
@lilislilit thanks for changing all exercises.
I'm wondering If this issue should be closed (because it's changed everywhere) or left open (as info for new exercises).
@M-a-Ge could you please un-merge my PR #514 because as @behrtam says in #521 there should be just one exercise per PR like in #510 (as written in contributing-guide).
(Maybe we could make one exception with this rule because it will create lot of PRs. But @behrtam is the boss here 😄 .)
I've just done this for the acronym.py template. I hope I did it ok, I am new to this! Please let me know if there is anything I could have done better.
@jankaifer, thanks for your list. I'm creating separate issues for each of these exercises as part of Hacktoberfest.
I hope you and @lilislilit will contribute since you've committed a lot of in this.
Activity
behrtam commentedon Aug 11, 2017
But shouldn't choosing a good name for parameters be part of solving the exercises?
jankaifer commentedon Aug 11, 2017
You can always rename it 😄
Maybe not names, just some strange placeholders, but something that tells me what my function gets as input. Something like inputString or array.
ilya-khadykin commentedon Aug 20, 2017
Fixed in #510
jankaifer commentedon Aug 21, 2017
@M-a-Ge well its not fixed yet because I fixed just one exercise. But others templates are still without parameters. If you find this a good idea then all exercises should be modified.
I don't know where to write it to let others know that new exercises should have parameters in template and to tell contributors that someone could upgrade other exercises as well.
ilya-khadykin commentedon Aug 21, 2017
@jankaifer, got it now
I'll reopen the issue then
jankaifer commentedon Aug 22, 2017
Thx
jankaifer commentedon Aug 22, 2017
Hi, could someone mark this as beginner-friendly or even first-timers-only please.
Thx
ilya-khadykin commentedon Aug 22, 2017
@jankaifer, I've added requested label.
lilislilit commentedon Sep 6, 2017
#521 Mostly covers it, I hope :)
jankaifer commentedon Sep 7, 2017
@lilislilit thanks for changing all exercises.
I'm wondering If this issue should be closed (because it's changed everywhere) or left open (as info for new exercises).
lilislilit commentedon Sep 7, 2017
@jankaifer As I was told in #521 comments, PR's should be separate for each exercise, so I guess, maybe add a checklist in top comment?
jankaifer commentedon Sep 7, 2017
@M-a-Ge could you please un-merge my PR #514 because as @behrtam says in #521 there should be just one exercise per PR like in #510 (as written in contributing-guide).
(Maybe we could make one exception with this rule because it will create lot of PRs. But @behrtam is the boss here 😄 .)
6 remaining items
sjwarner-bp commentedon Oct 2, 2017
I've just done this for the
acronym.pytemplate. I hope I did it ok, I am new to this! Please let me know if there is anything I could have done better.Acronym: update function to have params as in exercism#509
House: Added params to address Issue exercism#565 which is referenced…
Difference of Squares: Added params to address Issue exercism#565 ref…
Merge pull request #536 from sjwarner-bp/master
ilya-khadykin commentedon Oct 3, 2017
@jankaifer, thanks for your list. I'm creating separate issues for each of these exercises as part of Hacktoberfest.
I hope you and @lilislilit will contribute since you've committed a lot of in this.
minesweeper: Add parameter to exercise placeholder. Closes exercism#599
minesweeper: Add parameter to exercise placeholder. Closes exercism#599
jankaifer commentedon Oct 4, 2017
@M-a-Ge do you need help with merging PRs and closing issues?
ilya-khadykin commentedon Oct 4, 2017
@jankaifer it definitely take some time to go through all of them, to be honest.
Do you want to become a maintainer of the track?
jankaifer commentedon Oct 4, 2017
@M-a-Ge I would love to become a maintainer.
N-Parsons commentedon Jan 20, 2018
And I think we're done! Thanks for clearing the last few up, @cmccandless!