Repository navigation
Update tests starting with letters (R-Z) to use assertj - #2513
Merged
sanderploegsma merged 5 commits intoOct 6, 2023
Merged
Conversation
* Updates tests to use assertThat instead of assertEquals * Fix style check * Revert deprecated exercise changes * Fix style check * Revert imports change
Contributor
Author
|
Hi @sanderploegsma |
sanderploegsma
approved these changes
Oct 6, 2023
sanderploegsma
left a comment
sanderploegsma
left a comment
Contributor
There was a problem hiding this comment.
LGTM, although I found one possible improvement. Could you have a look at it?
Contributor
|
Thanks again! |
Contributor
Author
|
Thanks and welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull request for (#2147 )
In this PR, the following tests have been updated to use assertj
Reviewer Resources:
Track Policies