Skip to content

#1814 Implement exercise POV - #2226

Closed
aky91 wants to merge 236 commits into
exercism:mainfrom
aky91:main
Closed

aky91 wants to merge 236 commits into
exercism:mainfrom
aky91:main

Conversation

@aky91

@aky91 aky91 commented Dec 28, 2022

Copy link
Copy Markdown

PR Description

This PR aims to fix this issue: #1814
Changes include adding implementation for exercise POV in java


Reviewer Resources:

Track Policies

@aky91 aky91 changed the title WIP: #1814 Implement exercise POV #1814 Implement exercise POV Jan 2, 2023
if (o == null || getClass() != o.getClass()) return false;
Tree tree = (Tree) o;
return label.equals(tree.label)
&& children.size() == tree.children.size()

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: check for children list is order agnostic

@andrerfcsantos

andrerfcsantos commented Feb 25, 2023 •

Copy link
Copy Markdown
Member

@aky91 Thanks for this!

I completely messed up here, sorry. I was working on another repo and overrode the contents of your branch.
The contents and the commit history were not lost, so no work was lost and I made a new PR with your commits and some other changes I made, see #2264. But this meant that I couldn't recover your original branch, which would keep this PR open.

You will get reputation on the site for being the author of the exercise. However, this incident means you won't get additional reputation from creating a PR. To fix this, feel free to add a .meta/version file in this exercise's folder with 1.0.0 as the content and crate a PR with it. I'll merge that PR so you can get the rep. You may want to delete your fork and re-fork the repo for that PR, since it was the main branch that was affected.

I'm grateful for your work implementing the exercise and terribly sorry for the inconvenience caused. I'll make sure this won't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants