Skip to content

Convert exception assertions to AssertJ in SeriestTest #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrerfcsantos merged 3 commits into from
Oct 10, 2022
Merged

Convert exception assertions to AssertJ in SeriestTest #2172

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38470b9
Convert exception assertions to AssertJ in SeriestTest
kerolloz Oct 10, 2022
761e56f
Format test file
andrerfcsantos Oct 10, 2022
ddf711b
Remove unused import
andrerfcsantos Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 13 additions & 30 deletions exercises/practice/series/src/test/java/SeriesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertThrows;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;

import java.util.Arrays;
import java.util.Collections;
Expand Down Expand Up @@ -83,55 +82,39 @@ public void slicesOfLongSeries() {
public void sliceLengthIsToolarge() {
Series series = new Series("12345");

IllegalArgumentException expected =
assertThrows(
IllegalArgumentException.class,
() -> series.slices(6));

assertThat(expected)
.hasMessage("Slice size is too big.");
assertThatExceptionOfType(IllegalArgumentException.class)
.isThrownBy(() -> series.slices(6))
.withMessage("Slice size is too big.");
}

@Ignore("Remove to run test")
@Test
public void sliceLengthZero() {
Series series = new Series("12345");

IllegalArgumentException expected =
assertThrows(
IllegalArgumentException.class,
() -> series.slices(0));

assertThat(expected)
.hasMessage("Slice size is too small.");
assertThatExceptionOfType(IllegalArgumentException.class)
.isThrownBy(() -> series.slices(0))
.withMessage("Slice size is too small.");
}

@Ignore("Remove to run test")
@Test
public void sliceLengthNegative() {
Series series = new Series("123");

IllegalArgumentException expected =
assertThrows(
IllegalArgumentException.class,
() -> series.slices(-1));

assertThat(expected)
.hasMessage("Slice size is too small.");
assertThatExceptionOfType(IllegalArgumentException.class)
.isThrownBy(() -> series.slices(-1))
.withMessage("Slice size is too small.");
}

@Ignore("Remove to run test")
@Test
public void emptySeries() {
Series series = new Series("");

IllegalArgumentException expected =
assertThrows(
IllegalArgumentException.class,
() -> series.slices(1));

assertThat(expected)
.hasMessage("Slice size is too big.");
assertThatExceptionOfType(IllegalArgumentException.class)
.isThrownBy(() -> series.slices(1))
.withMessage("Slice size is too big.");
}

}