Skip to content

nucleotide-count: sync sample solution and test class names #697

Closed

Description

@FridaTveit

As far as I'm aware it's best practice to name a test class after the class it's testing. So if you're testing SomeClass you would name the test class SomeClassTest. We usually do this but in nucleotide-count we have NucleotideTest which test the class DNA. I suggest we:

  1. Rename NucleotideTest to DNATest (or possibly Dna and DnaTest to make it more readable?)
  2. Add this preference to the POLICIES doc

Do you agree with this @exercism/java?

Activity

  1. Smarticles101 commented on Jul 10, 2017

    @Smarticles101
    Member

    What if we renamed the DNA class to Nucleotide or NucleotideCount? Normally, the solution class is named after the exercise. Other than that, I think adding what you said to the POLICIES doc is a great idea.

  2. stkent commented on Jul 10, 2017

    @stkent
    Contributor

    +1 NucleotideCount, or even NucleotideCounter.
    +1 a new entry under the 'best practices' section of the policies.

  3. changed the title [-]Name test class after class under test[/-] [+]nucleotide-count: sync sample solution and test class names[/+] on Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions