You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
nucleotide-count: sync sample solution and test class names #697
As far as I'm aware it's best practice to name a test class after the class it's testing. So if you're testing SomeClass you would name the test class SomeClassTest. We usually do this but in nucleotide-count we have NucleotideTest which test the class DNA. I suggest we:
Rename NucleotideTest to DNATest (or possibly Dna and DnaTest to make it more readable?)
What if we renamed the DNA class to Nucleotide or NucleotideCount? Normally, the solution class is named after the exercise. Other than that, I think adding what you said to the POLICIES doc is a great idea.
Activity
Smarticles101 commentedon Jul 10, 2017
What if we renamed the
DNAclass toNucleotideorNucleotideCount? Normally, the solution class is named after the exercise. Other than that, I think adding what you said to the POLICIES doc is a great idea.stkent commentedon Jul 10, 2017
+1
NucleotideCount, or evenNucleotideCounter.+1 a new entry under the 'best practices' section of the policies.
[-]Name test class after class under test[/-][+]nucleotide-count: sync sample solution and test class names[/+]