Skip to content

roman-numerals: update version file and add test (1.0.0 -> 1.2.0) #1355

Closed

Description

@FridaTveit

Please update the version specified in the roman-numerals version file from 1.0.0 to 1.2.0.

Please also include one extra test which is included in the canonical data but not in our tests; between the tests for converting 48 and converting 59 there should be a test for converting 49.

Background info: each exercise which has canonical data should have a version file. This file states which version of the canonical data the exercise implements. The version can be found at the top of the canonical data file for that exercise.

Activity

  1. katmpatz commented on Apr 10, 2018

    @katmpatz
    Contributor

    @FridaTveit, if this issue is already open I would really want to contribute!

  2. sjwarner-bp commented on Apr 10, 2018

    @sjwarner-bp
    Contributor

    Feel free to pick this one up @katmpatz ! 🙂

  3. FridaTveit commented on Apr 10, 2018

    @FridaTveit
    ContributorAuthor

    Yes, go for it @katmpatz 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions