Skip to content

rework toc for jupyter-book PR #817#15

Merged
najuzilu merged 2 commits intomasterfrom
fix-build
Jul 30, 2020
Merged

rework toc for jupyter-book PR #817#15
najuzilu merged 2 commits intomasterfrom
fix-build

Conversation

@mmcky
Copy link
Copy Markdown
Member

@mmcky mmcky commented Jul 30, 2020

This should fix the build failure

@welcome
Copy link
Copy Markdown

welcome Bot commented Jul 30, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@mmcky mmcky requested a review from najuzilu July 30, 2020 05:46
@mmcky
Copy link
Copy Markdown
Member Author

mmcky commented Jul 30, 2020

@najuzilu is this use of chapter in the new release of jupyter-book=0.7.3 the same as the old header approach?

@najuzilu
Copy link
Copy Markdown
Member

That's my understanding as well...

@najuzilu najuzilu merged commit 969a99f into master Jul 30, 2020
@welcome
Copy link
Copy Markdown

welcome Bot commented Jul 30, 2020

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants