Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honor the existing
versionargument when loading and hashing HumanEval+._ready_human_eval_plus_path()resolvesversion, but then passes the constantHUMANEVAL_PLUS_VERSIONtoget_dataset_metadata(). Independently,get_human_eval_plus_hash()replaces its caller's version with"default". As a result, requesting an older release can silently read and hash the default release instead.Forward the resolved/caller-supplied version in these two places, matching the existing MBPP+ implementation. Default-version behavior and
HUMANEVAL_OVERRIDE_PATHprecedence remain unchanged. No release data, scoring logic, cache format, or dependencies are changed.Tests
Added offline tests using synthetic JSONL files in pytest's temporary directory. Only
make_cache()is mocked: metadata/path construction, file loading, completeness checking, and hashing use the real implementations.Black 22.6.0, isort 5.12.0 with the Black profile, and
git diff --checkpass. No benchmark dataset downloads, generated-code execution, model calls, or full-suite run.AI assistance: implemented and tested with OpenAI Codex.