Skip to content

branch confusion #466

Closed
Closed
branch confusion#466

Description

@dlech
dlech
opened on May 5, 2018
  1. There appears to be commits for ev3dev-stretch in the jessie branch
  2. What is the purpose of the ev3dev2-namespace branch? It seems that the stretch branch contains the ev3dev2 namespace already.
  3. There is no branch for the 1.x releases (tags).

Activity

  1. dlech commented on May 5, 2018

    @dlech
    dlech
    on May 5, 2018
    MemberAuthor

    Re: item 3, the reason I am asking about this is because I am going to go ahead do a v1.2.0 release that fixes the kernel breakage in ev3dev-stretch since it doesn't appear that 2.x is ready for release yet.

  2. dwalton76 commented on May 5, 2018

    @dwalton76
    dwalton76
    on May 5, 2018
    Collaborator

    Item 1: can you point me at some of them?

    Item 2: I am pretty sure ev3dev2-namespace can be deleted but I was waiting for confirmation from @WasabiFan, see #449.

  3. dlech commented on May 5, 2018

    @dlech
    dlech
    on May 5, 2018
    MemberAuthor

    Item 1: can you point me at some of them?

  4. dwalton76 commented on May 6, 2018

    @dwalton76
    dwalton76
    on May 6, 2018
    Collaborator

    I don’t have a good answer...looks like we made a mistake :(

  5. dlech commented on May 6, 2018

    @dlech
    dlech
    on May 6, 2018
    MemberAuthor

    So how should we fix it?

  6. WasabiFan commented on May 20, 2018

    @WasabiFan
    WasabiFan
    on May 20, 2018
    Member

    I've been out of the loop; it looks like the only problematic changes in those two commits are the updates to the LED and button strings, is that correct? Assuming this wasn't already done, does anyone see a reason not to revert those two particular parts of those changes in a new commit? Also, why hasn't anyone encountered an issue with that yet (or have they, and I'm just oblivious)?

  7. ddemidov commented on May 20, 2018

    @ddemidov
    ddemidov
    on May 20, 2018
    Member

    Assuming this wasn't already done, does anyone see a reason not to revert those two particular parts of those changes in a new commit?

    👍

    Also, why hasn't anyone encountered an issue with that yet (or have they, and I'm just oblivious)?

    Probably because the changes to jessie were made after the package was released?

  8. WasabiFan commented on Jul 29, 2018

    @WasabiFan
    WasabiFan
    on Jul 29, 2018
    Member

    I believe this has been fixed; please reopen if it's still an issue.

  9. WasabiFan
    closed this as completedon Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions