Skip to content

Use =default for constructors and operator= where possible #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etr merged 8 commits into from
Feb 26, 2020
Merged

Use =default for constructors and operator= where possible #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6f0df98
Use default constructor and operator= where possible: etr/libhttpserv…
bcsgh Feb 24, 2020
094bc5c
Remove some noexcept's from operator=(T&&) that newer versions of cla…
bcsgh Feb 24, 2020
f8c6176
Remove more noexcept's from operator=(T&&) that newer versions of cla…
bcsgh Feb 24, 2020
db6f556
Remove more noexcept's from operator=(T&&) that newer versions of cla…
bcsgh Feb 24, 2020
e5116a9
Remove more noexcept's from operator=(T&&) that newer versions of cla…
bcsgh Feb 24, 2020
ac40620
Revert some incedental changes for now.
bcsgh Feb 24, 2020
90f738a
Revert some incedental changes for now (http_request).
bcsgh Feb 24, 2020
9fee8a8
Refactor another class that got missed in the first pass.
bcsgh Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 7 additions & 40 deletions src/httpserver/basic_auth_fail_response.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ namespace httpserver
class basic_auth_fail_response : public string_response
{
public:
basic_auth_fail_response():
string_response(),
realm("")
{
}
basic_auth_fail_response() = default;

explicit basic_auth_fail_response(
const std::string& content,
Expand All @@ -50,46 +46,17 @@ class basic_auth_fail_response : public string_response
{
}

basic_auth_fail_response(const basic_auth_fail_response& other):
string_response(other),
realm(other.realm)
{
}

basic_auth_fail_response(basic_auth_fail_response&& other) noexcept:
string_response(std::move(other)),
realm(std::move(other.realm))
{
}

basic_auth_fail_response& operator=(const basic_auth_fail_response& b)
{
if (this == &b) return *this;

(string_response&) (*this) = b;
this->realm = b.realm;
basic_auth_fail_response(const basic_auth_fail_response& other) = default;
basic_auth_fail_response(basic_auth_fail_response&& other) noexcept = default;
basic_auth_fail_response& operator=(const basic_auth_fail_response& b) = default;
basic_auth_fail_response& operator=(basic_auth_fail_response&& b) = default;

return *this;
}

basic_auth_fail_response& operator=(basic_auth_fail_response&& b)
{
if (this == &b) return *this;

(string_response&) (*this) = std::move(b);
this->realm = std::move(b.realm);

return *this;
}

~basic_auth_fail_response()
{
}
~basic_auth_fail_response() = default;

int enqueue_response(MHD_Connection* connection, MHD_Response* response);

private:
std::string realm;
std::string realm = "";
};

}
Expand Down
Loading