Skip to content

Enable body for delete requests and enable patch requests#151

Merged
etr merged 11 commits into
masterfrom
body_methods_2
Aug 8, 2019
Merged

Enable body for delete requests and enable patch requests#151
etr merged 11 commits into
masterfrom
body_methods_2

Conversation

@etr

@etr etr commented Aug 7, 2019

Copy link
Copy Markdown
Owner

Issue or RFC Endorsed by Maintainers

#150

Description of the Change

This change enables the following two features:

  • Request body processing for DELETE requests
  • Support for PATCH requests

Verification Process

Unit/Integration tests

Release Notes

Added support for body parsing in DELETE requests.
Added support for PATCH method

@etr etr added api Related to libhttpserver's public APIs. feature-request Feature requests or enhancements labels Aug 7, 2019
@etr etr self-assigned this Aug 7, 2019
@codecov-io

codecov-io commented Aug 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #151 into master will decrease coverage by 1.28%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   96.55%   95.26%   -1.29%     
==========================================
  Files          34       34              
  Lines        3019     3169     +150     
==========================================
+ Hits         2915     3019     +104     
- Misses        104      150      +46
Impacted Files Coverage Δ
src/httpserver/http_utils.hpp 100% <ø> (ø) ⬆️
src/httpserver/http_resource.hpp 41.17% <0%> (+3.24%) ⬆️
src/http_resource.cpp 84.61% <100%> (+1.28%) ⬆️
test/integ/basic.cpp 99.67% <100%> (ø) ⬆️
src/httpserver/deferred_response.hpp 100% <100%> (ø) ⬆️
test/integ/deferred.cpp 100% <100%> (ø) ⬆️
src/webserver.cpp 90.39% <100%> (+1.54%) ⬆️
src/http_utils.cpp 99.17% <100%> (ø) ⬆️
src/deferred_response.cpp 100% <100%> (ø) ⬆️
src/httpserver/string_response.hpp 40% <0%> (-60%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5fb24...088c9d0. Read the comment docs.

@etr
etr merged commit 6d77ac5 into master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Related to libhttpserver's public APIs. feature-request Feature requests or enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants