Repository navigation
Conversation
jmmv
force-pushed
the
issue-136
branch
2 times, most recently
from
December 8, 2021 17:48
bac9ced to
e6cb33f
Compare
There are a bunch of key presses that should be recognized by EndBASIC but that are also recognized by the browser. Some include the Tab key, the arrow keys (when "caret browsing" is enabled), and the slash key in Firefox. Before, pressing any of these keys would cause the browser to also perform their default action, which meant that the REPL would misbehave by losing focus or triggering links. With this change, we prevent the events from propagating to the browser once we have handled them so that this problem doesn't surface. Manually tested this on an iPad and on an Android emulator and there don't seem to be regressions with the previous behavior. This change is inspired by the fix submitted by @Protowalker in #140. Fixes #136.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a bunch of key presses that should be recognized by EndBASIC
but that are also recognized by the browser. Some include the Tab key,
the arrow keys (when "caret browsing" is enabled), and the slash key
in Firefox.
Before, pressing any of these keys would cause the browser to also
perform their default action, which meant that the REPL would misbehave
by losing focus or triggering links. With this change, we prevent the
events from propagating to the browser once we have handled them so
that this problem doesn't surface.
This change is inspired by the fix submitted by @Protowalker in #140.
Fixes #136.