Skip to content

Don't always encode forward slashes as %2F in query parameters #2864

Closed as not planned

Description

@scnerd

#2723 Transitions to encoding "/" as "%2F" in the query; the argument is that this is "more correct" and more inline with browsers' default behavior.

The problem is that some API's simply reject this; for them, the two encodings are not identical. A comment on #2721 remarks that the OpenAI API expects actual slashes. I'm dealing with a private backend (that I don't control) that likewise expects actual slashes.

This new behavior should be possible to opt out of.

Activity

  1. thetanz-geoff commented on Sep 29, 2023

    @thetanz-geoff

    @scnerd: This is raised in discussions (per the rules: "Please only raise an issue if you've been advised to do so after discussion.") here:
    #2856
    #2863

    Suggest you keep an eye on all 3 threads for a response, and downgrade to 0.24.1 in the interim.

  2. zanieb commented on Sep 29, 2023

    @zanieb
    Contributor

    Closing in favor of the existing discussions for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions