Release InstaPy on PyPi with versioning#3887
Merged
timgrossmann merged 65 commits intomasterfrom Feb 4, 2019
Merged
Conversation
From now on, assets folder is gonna reside at user's workspace folder. *chromedriver will be there too
It is best to have InstaPy extensions get through pip.
When instapy package is installed through pip then icons folder will reside inside the instapy folder. Without this change, it would reside in a separate folder at the same level with instapy package which is not good. With setuptools it is impossible to make it work otherwise (it was possible with old distutils).
… & make a sample test file Although those old tests are deprecated and incompatible with today's code, they are very decent and written by a tester professional. So that, it's best to fix the incompatibilities in them and serve them as strong tests to be run by pytest.
From now on, it will reside in the user's workspace folder and operate as before. All of the files will be generated during runtime as requested.
…g custom workspace
Having version information stored here will help to get it as ```instapy.__version__``` Also, it will ease changing version number each time from here rather than from setup.py[setup()].
…le to be imported to other modules easily. In future can write other custom-exceptions here in the same file.
… better handling and stability It checks the current chromedriver locations if exists, if not makes sure assets folder exist and then asks user to put chromedriver executable to that folder.
…on or from pip's install location using pkg_resources module
…ew priority to highlight_print() And relocate imports.
…ckage of plyer package for old pythons - Since new plyer is available (2 new versions released) the bug with python 2.7 has been resolved. Now it will work for 2.7.15 and in future if verified, can be enabled for olders, too. - Some other visual changes, pass a logfolder, etc.
It is highly flexible and acts as before. Apparently, you can set custom locations like, Settings.database_locations = "home\dbis\instapy.db" any time.
File managemer module is wrriten to handle every worse scenario. set_workspace() function here is part of user interface and get_workspace() can also be used like so.
Changes: - `python_requires` refined; - remove deprecated `classifiers` - add new packages to extra test requirements; - update keywords; - use package_data to bundle data files into distributions - get version info from __init__.py module - update summary; - load README.md and data from __init__.py using re and io modules; - add a few more project URLs and remove deprecated
…lso be used by other tools like tox
Run multi-python tests with pytest and also static analysis tests with flake8.
…es. also auto-deploy to PyPI & Discord notifications
There was a missing , between the parameters
added instapy-chromedriver package if no chromedriver is in path
Remove - `set_relationship_bounds()` - `set_dont_like()` - login credentials example - headless mode example
Extras - choose editable install (`-e` flag) for advanced installation - some <br /> newlines for good structural look - align the position of donation buttons for good looks - add 3 horizontal space to Discord's button for good looks xD - other neat visual changes
…lags conflicting with reserved args. Supports Python >= 2.7 See https://docs.python.org/3/library/argparse.html#allow-abbrev to understand more of this behaviour.
Pass arguments by CLI
Contributor
|
Great! So now that InstaPy is live on PyPi, should users move from the "old" GitHub version to the PyPi version? And if so, how do we transfer our database? |
Collaborator
Author
|
@TarekJ03 Takes another half an hour 😉 Simply copy&paste the content of your logs folder to the logs folder that will be created with the first run of InstaPy installed with pip. You can still use the InstaPy from GitHub, the master branch will hold the same state. |
uluQulu
approved these changes
Feb 4, 2019
This was referenced Feb 4, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version [0.1.1] - 2019-02-04
Added