Repository navigation
ensure that we start logging from the beginning of the line - #6
Merged
Merged
Conversation
Collaborator
|
@ghedamat I think this may break downstream tests which attempt to mock |
4 of 5 tasks
Contributor
Author
|
@lukemelia you might be correct indeed. the reason why I'm reaching to the original stream is because ember-cli wraps the outputStream so that it can play nicely with the are we ok in adding a guard to see if |
Collaborator
|
I guess I am ok with that, with a comment. I don't have a ton of experience with the arcane art of terminal output. |
ghedamat
force-pushed
the
log-tweaks
branch
3 times, most recently
from
January 11, 2016 03:43
bb9ffee to
ff8a67a
Compare
This is related to ember-cli-deploy/ember-cli-deploy#280 In order to ensure proper rendering we need to reset the line position to 0. This can not be the case if the progress bar is rendering and a plugin tries to display a log message (i.e. the redis plugin notifying about the upoaded revision)
lukemelia
added a commit
that referenced
this pull request
Jan 11, 2016
ensure that we start logging from the beginning of the line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to ember-cli-deploy/ember-cli-deploy#280
In order to ensure proper rendering we need to reset the line position
to 0. This can not be the case if the progress bar is rendering and a
plugin tries to display a log message (i.e. the redis plugin notifying
about the upoaded revision)
/cc @lukemelia