Conversation
2 tasks done
Collaborator
|
@lolmaus that is definitely interesting, I'm quite sure it used to work in the past... see https://travis-ci.org/ember-cli-deploy/ember-cli-deploy/builds/133134377 for example I wonder what changed I'd rather avoid listing all directories because we could miss one when we add more test.. I'll do a couple of quick experiments and if they fail will merge in the meantime thanks! |
Collaborator
Author
|
@ghedamat It happened to me locally too! I'm on Linux. |
Collaborator
|
werd, try to see if master is now working correctly with my fix if you can thanks! |
Author
Collaborator
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed & Why
I've noticed that
npm run testonly runs tests fromindex-test.js.Here's the latest build on
masteras of Feb 20:https://travis-ci.org/ember-cli-deploy/ember-cli-deploy/builds/201523239
For some reason, the glob
**works as a single asterisk*, meaning exactly one level of depth. I've updated Mocha, but it didn't resolve the problem.--recursivedidn't help either.So I updated the test command to include paths with two distinct levels of depth.
Bonus
Bumped
mochaversion.People
@lukemelia @LevelbossMike