Repository navigation
Allow loading .env files + .env.deploy.<env> files - #342
Merged
ghedamat merged 1 commit intoJan 10, 2016
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
I added this comment here because the behavior in dotenv seem backwards to me. I would expect overrides to be loaded last!
Collaborator
There was a problem hiding this comment.
interesting, yeah I think dotenv discards already defined vars so you can do overrides using the process ENV
Collaborator
|
@blimmer LGTM, unless @achambers or @lukemelia have anything to add I think we're good could you squash the commits please? Finally once we merge it would be ideal to add this to the guides, if you're up for it a PR against the temporary branch for 0.6.X docs would be amazing https://github.com/ember-cli/ember-cli-deploy/tree/gh-pages-0.6.x-first-pass |
Contributor
Author
|
Squash is complete. I will start working on the PR against the docs. Thanks! |
blimmer
force-pushed
the
feature/use-default-dotenv-files
branch
from
January 10, 2016 17:13
b78887c to
c91b49a
Compare
Contributor
|
👍 |
ghedamat
added a commit
that referenced
this pull request
Jan 10, 2016
Allow loading .env files + .env.deploy.<env> files
Collaborator
|
Thanks! |
lukemelia
pushed a commit
that referenced
this pull request
Jan 22, 2016
To document the behavior introduced in #342.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #341.