display progress notification during deploy - #280

shall we make the progress thingy optional if --verbose is passed?

I don't want to rush this into 0.5.0. I'd suggest saving it for 0.5.1.

works for me :)

Woo hoo this would be awesome!

current status
http://gsnaps.s3.amazonaws.com/screencast_2016-01-08_14-54-36_0_edited.mp4

we don't count configure hooks

we trigger a tick for each of the other hooks, in my demo app we have 10 ticks in total

it's still a bit "choppy" because some hooks are faster than other but I think it's not bad.

feedback is welcome

@lukemelia @achambers @seawatts

also, this currently runs also for deploy:list and deploy:activate and ends up looking quite weird.

maybe we should pass an option and do it only for deploy?

once we merge ember-cli-deploy/ember-cli-deploy-plugin#6 and update the relevant plugins we should solve the overlap problem

http://gsnaps.s3.amazonaws.com/screencast_2016-01-10_22-06-28_0_edited.mp4

Now with increased niceness
http://gsnaps.s3.amazonaws.com/screencast_2016-01-12_18-19-02_0_edited.mp4

👍

On Tue, Jan 12, 2016 at 3:21 PM, Mattia Gheda [email protected]
wrote:

Now with increased niceness
http://gsnaps.s3.amazonaws.com/screencast_2016-01-12_18-19-02_0_edited.mp4

(note that I'll have to add a tweak to ember-cli-deploy-plugin for this
to work properly)

—
Reply to this email directly or view it on GitHub
#280 (comment)
.

Chris Watts | Software Engineer | [email protected]

fancy

@lukemelia @stefanpenner you might know this

what's the consensus on adding an emoji to a command line prompt? from experience I know it likely won't work on linux terminals, so I'm kind of against it but it would be cute (I was thinking of 🚀)

💅

@ghedamat no idea of tech details of terminal emoji, but we could probably platform detect, I am 👍 🚀 ❗

ok, to whom is interested, now I consider this ready for review :p

only thing to note is that from what I can tell ember-cli help won't print long aliases correctly (maybe this should be a separate PR)

i.e.

--show-progress is aliased to -p and --progress

but the help is printed as

ember deploy <deployTarget> <options...>
  Deploys an ember-cli app
  --deploy-config-file (String) (Default: config/deploy.js)
  --verbose (Boolean) (Default: false)
  --activate (Boolean) (Default: false)
  --show-progress (Boolean) (Default: true)
    aliases: -p, -progress

it seems that when using it both -progress and --progress are being supported
see https://github.com/ember-cli/ember-cli/blob/282641ba662292afb40cb88cdf31557a3e4cc6b7/lib%2Futilities%2Fprint-command.js#L76

EDIT:
just opened ember-cli/ember-cli#5380 that should address ^^

@ghedamat looks great! I have one last idea for your consideration. Shall we only default this to true if the command is being run from a terminal? Seems like we can check process.stdout.isTTY (source)

@lukemelia done directly in the deploy command so that it's the default

minor problem is: if you use .ember-cli option that will override the default, but I don't see why one would force it to "true" as that's the standard behaviour anyway

Great work @ghedamat!