Repository navigation
[ENHANCEMENT] print double dash for long aliases in availableOptions - #5380
Merged
Merged
Conversation
4 of 5 tasks
Contributor
Author
|
tests will fail as some existing options will be changed by this (in the printed help) example test failure: --live-reload-port (Number) (Defaults to port number within [49152...65535])
- aliases: --lrp <value>
+ aliases: -lrp <value>before going in and changing the tests I'd like to know if the ember-cli team is ok with this change or if the current is intended behaviour and should be kept as is. another option would be to consider printing thanks! |
Contributor
Contributor
Author
|
thanks @stefanpenner , if we set the limit to 4 chars instead of one the only help that would change are for the |
Member
|
Ya, I agree that this is a good idea. |
note: presently if one alias for the availableOptions is a long word the help function for that command will still print the option with a single dash although the `--` version seems to work fine i.e. https://github.com/ember-cli/ember-cli/blob/282641ba662292afb40cb88cdf31557a3e4cc6b7/lib%2Fcommands%2Fbuild.js#L13 will be printed as `-dev` even if also `--dev` is supported. before: aliases: -a <value>, -long-a <value>, -b (--test-option=c) after: aliases: -a <value>, --long-a <value>, -b (--test-option=c)
ghedamat
force-pushed
the
print-command-long-aliases
branch
from
January 21, 2016 16:42
5929f0c to
d05fcd0
Compare
Contributor
Author
|
@stefanpenner @rwjblue appveyor is still running but I think we're good I settled on a 4 char limit, let me know if that sounds good thanks! |
Contributor
|
lgtm 👍 |
Contributor
|
@homu r+ |
Contributor
|
📌 Commit d05fcd0 has been approved by |
homu
added a commit
that referenced
this pull request
Jan 21, 2016
…nner [ENHANCEMENT] print double dash for long aliases in availableOptions Presently if one alias for `availableOptions` is a long word the help function for that command will still print the option with a single dash although the `--` version works as well. i.e. https://github.com/ember-cli/ember-cli/blob/282641ba662292afb40cb88cdf31557a3e4cc6b7/lib%2Fcommands%2Fbuild.js#L13 will be printed as `-dev` even if also `--dev` is supported. before this patch: ``` aliases: -a <value>, -long-a <value>, -b (--test-option=c), -long-b (--test-option=c) ``` after: ``` aliases: -a <value>, --long-a <value>, -b (--test-option=c), --long-b (--test-option=c) ```
Contributor
Contributor
|
💔 Test failed - status |
Contributor
|
@homu retry |
Contributor
homu
added a commit
that referenced
this pull request
Jan 22, 2016
…nner [ENHANCEMENT] print double dash for long aliases in availableOptions Presently if one alias for `availableOptions` is a long word the help function for that command will still print the option with a single dash although the `--` version works as well. i.e. https://github.com/ember-cli/ember-cli/blob/282641ba662292afb40cb88cdf31557a3e4cc6b7/lib%2Fcommands%2Fbuild.js#L13 will be printed as `-dev` even if also `--dev` is supported. before this patch: ``` aliases: -a <value>, -long-a <value>, -b (--test-option=c), -long-b (--test-option=c) ``` after: ``` aliases: -a <value>, --long-a <value>, -b (--test-option=c), --long-b (--test-option=c) ```
Contributor
|
☀️ Test successful - status |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently if one alias for
availableOptionsis a long word the help function for that command will still print the option with a single dash although the--version works as well.i.e.
ember-cli/lib/commands/build.js
Line 13 in 282641b
will be printed as
-deveven if also--devis supported.before this patch:
after: