Fix max_lifetime docstring inaccuracies, validation, and typos#345
Merged
josevalim merged 1 commit intoelixir-ecto:masterfrom Apr 25, 2026
Merged
Conversation
- docstring: replace `idle_limit` (a count) with `2 * idle_interval` in the worst-case idle-wait formula; the addition was dimensionally incorrect. - docstring: drop "and on checkout" — `conn(:ts)` is set only at connection establishment, never reset on checkout. - docstring: fix "you ca set it" typo. - connection_pool: reject negative or descending `:max_lifetime` ranges (e.g. `100..50//1`) at init instead of letting them flow into `:erlang.phash2/2` and be silently swallowed by the rescue in `Holder.maybe_disconnect/4`. - holder: rename misspelled `ellapsed` to `elapsed`.
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idle_limit(a count) with2 * idle_intervalin the worst-case idle-wait formula; the addition was dimensionally incorrect.conn(:ts)is set only at connection establishment, never reset on checkout.:max_lifetimeranges (e.g.100..50//1) at init instead of letting them flow into:erlang.phash2/2and be silently swallowed by the rescue inHolder.maybe_disconnect/4.ellapsedtoelapsed.