Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: elixir-ecto/db_connection
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: elixir-ecto/db_connection
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: jf-shared-stop
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Oct 10, 2017

  1. Checkin previous connections when setting ownership mode to shared

    This fixes a bug where processes started before the ownership
    mode is set to shared holds on to the previous connection,
    causing confusion.
    José Valim committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    a238a12 View commit details
    Browse the repository at this point in the history
  2. Always check in all connections on mode change

    José Valim committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    aa30330 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2017

  1. Strictly revoke ownership of allowed processes on proxy checkin

    If a process is allowed on a connection/proxy that is checked in the
    process is marked revoked and requires explicit checkout/allow to
    regain an allowance on a process.
    
    Note that shared mode is as an explicit allow, and so delays the revoking
    until the shared mode ends. If shared mode is enter multiple times in a
    row the revoke is delayed each time. Also caller: pid will continue to work.
    
    In practice this means the only new time a new failure occurs is when a
    process is allowed on a connection/proxy that gets checked in, it can not
    gain a new connection in automatic mode without explicit checkout/allow.
    In the same situation in manual mode the error warns about revoking but
    an explicit checkout/allow was required.
    fishcakez committed Oct 22, 2017
    Configuration menu
    Copy the full SHA
    a13cfe1 View commit details
    Browse the repository at this point in the history
Loading