Repository navigation
fix: Device.as_dict() raised TypeError for any device with a node - #88
Merged
Merged
Conversation
It built each node entry as a set literal, {node_id, node.as_dict()},
which hashes the node's dict. Adds a regression test with a node; a device
with no nodes returned normally, which is why nothing caught it.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01T32pvgqCzp1qCz7K5gS9Wm
dcj
force-pushed
the
dcj/device-as-dict-fix
branch
from
October 4, 2026 05:57
bf5276a to
f307e83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87.
homie.Device.as_dict()built each node entry as a set literal,{node_id, node.as_dict()}, so it raisedTypeError: unhashable type: 'dict'for any device with a node. Nownodes[node_id] = node.as_dict(), with a regression test that fails before the fix.The CHANGELOG entry sits under
[Unreleased]next to #86's; whichever merges second needs a rebase.🤖 Generated with Claude Code
https://claude.ai/code/session_01T32pvgqCzp1qCz7K5gS9Wm