This repository was archived by the owner on Nov 4, 2022. It is now read-only.
Duplo api - #392
Open
SychovOleh wants to merge 14 commits into
Open
Conversation
SychovOleh
commented
Jan 20, 2020
anton-kotenko
suggested changes
Jan 21, 2020
anton-kotenko
left a comment
anton-kotenko
left a comment
Contributor
There was a problem hiding this comment.
I see here only new api.
But we've changed a lot of other api endpoints (flows, credentials, one-time-executions, flow-draft, ....)
Do you have plans to update documentation for this endpoints
SychovOleh
requested review from
HannaTrotsenko,
anton-kotenko and
honeybadgeralex
January 22, 2020 09:46
honeybadgeralex
approved these changes
Jan 22, 2020
drobiazko
suggested changes
Jan 30, 2020
| "attributes":{ | ||
| "name":"agent name", | ||
| "status":"online", | ||
| "port_mapping":[{ |
Contributor
There was a problem hiding this comment.
Is port_mapping a good name if this object contains properties like destination_ip, destination_port, protocol, etc.?
Contributor
There was a problem hiding this comment.
Reasoning:
we map bloody-gate-service.platform.cluser.local:$port to $destination_ip:$destnation_port
That's why mapping.
Probably you're right that in this case port_ is slightly misleading
Contributor
There was a problem hiding this comment.
| "status":"online", | ||
| "port_mapping":[{ | ||
| "destination_ip": '1.1.1.1', | ||
| destination_port: 8888, |
Contributor
|
@drobiazko are we going to release this or not? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.