don't touch body if capture_body is False#817
Merged
Conversation
So far, we still looked at the request body, even if capture_body was disabled. This was so we only set the `[REDACTED]` flag if there actually was a body. Unfortunately, this interferes with streaming requests. Fixes elastic#816
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
basepi
approved these changes
May 6, 2020
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
May 6, 2020
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
So far, we still looked at the request body, even if capture_body was disabled. This was so we only set the `[REDACTED]` flag if there actually was a body. Unfortunately, this interferes with streaming requests. Fixes elastic#816
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
So far, we still looked at the request body, even if capture_body was disabled. This was so we only set the `[REDACTED]` flag if there actually was a body. Unfortunately, this interferes with streaming requests. Fixes elastic#816
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
So far, we still looked at the request body, even if capture_body was disabled. This was so we only set the `[REDACTED]` flag if there actually was a body. Unfortunately, this interferes with streaming requests. Fixes elastic#816
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
So far, we still looked at the request body, even if capture_body
was disabled. This was so we only set the
[REDACTED]flag ifthere actually was a body. Unfortunately, this interferes with
streaming requests.
I haven't found a way to properly test this. Any suggestions?
Related issues
closes #816