Add Starlette / FastAPI middleware#694
Conversation
Sparkycz
force-pushed
the
fastapi
branch
3 times, most recently
from
fd5aee0 to
f0f9fff
Compare
basepi
left a comment
basepi
left a comment
There was a problem hiding this comment.
This looks really excellent at first glance. I'll be reviewing it in more detail, but before I do, can you please put the starlette tests (and the aiohttp tests you renamed) under tests/contrib/asyncio please? That directory is automatically excluded from the test matrix for versions of cpython and pypy that don't support the async def pattern.
We'll also need you to sign the CLA.
Once we get that done I'll get the tests running.
basepi
left a comment
basepi
left a comment
There was a problem hiding this comment.
Couple of changes independent of anything we find in the tests.
|
jenkins run the tests please |
1 similar comment
|
jenkins run the tests please |
|
@Sparkycz Please remember to sign the CLA. I've noticed that your commits are not associating with your Github account. I recommend adding your commit email ( Alternatively you could rebase the commits with a Github-associated email. Without a signed CLA we unfortunately will not be able to accept this excellent contribution. |
|
Rebased all commits due to CLA only.. |
|
Should I squash all the commits to one? |
|
jenkins run the tests please |
|
No, we use squash and merge so it should be fine. |
4 participants
Closes #686