unwrap pg connection/cursor for new psycopg2 extensions#621
Merged
Conversation
beniwohli
force-pushed
the
fix-620
branch
3 times, most recently
from
edf2008 to
4664264
Compare
jalvz
approved these changes
Oct 31, 2019
basepi
approved these changes
Nov 11, 2019
psycopg2 2.8 added two new extensions, `quote_ident` and `encrypt_password`. Both extensions do a type check on the connection/cursor object, which fails if they are wrapped with our object proxies. Similar to `register_type`, we need to unwrap the connection/cursor before handing it to these extensions. fixes elastic#620
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
psycopg2 2.8 added two new extensions,
quote_identandencrypt_password. Both extensions do a type check on theconnection/cursor object, which fails if they are wrapped with our
object proxies. Similar to
register_type, we need to unwrap theconnection/cursor before handing it to these extensions.
fixes #620