capture destination host for instrumentations of services#618
Merged
Conversation
beniwohli
force-pushed
the
db-destination
branch
from
6c40a6a to
e1c5581
Compare
basepi
approved these changes
Mar 18, 2020
basepi
left a comment
basepi
left a comment
Contributor
There was a problem hiding this comment.
Looks great. One question about a filename, otherwise 👍 👍
messense
reviewed
Apr 8, 2020
| cls_name, method_name = method.split(".", 1) | ||
| signature = ".".join([instance.full_name, method_name]) | ||
| with capture_span(signature, span_type="db", span_subtype="mongodb", span_action="query", leaf=True): | ||
| host, port = instance.database.client.address |
Contributor
There was a problem hiding this comment.
Some how this caused exception with PyMongo 3.9.0: TypeError: cannot unpack non-iterable NoneType object
Traceback (most recent call last):
File "/srv/brm-api_staging/venv/lib/python3.8/site-packages/flask/app.py", line 2447, in wsgi_app
response = self.full_dispatch_request()
File "/srv/brm-api_staging/venv/lib/python3.8/site-packages/flask/app.py", line 1952, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/srv/brm-api_staging/venv/lib/python3.8/site-packages/flask_cors/extension.py", line 161, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
File "/srv/brm-api_staging/venv/lib/python3.8/site-packages/flask/app.py", line 1821, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/srv/brm-api_staging/venv/lib/python3.8/site-packages/flask/_compat.py", line 39, in reraise
raise value
File "/srv/brm-api_staging/venv/lib/python3.8/site-packages/flask/app.py", line 1950, in full_dispatch_request
rv = self.dispatch_request()
File "/srv/brm-api_staging/venv/lib/python3.8/site-packages/flask/app.py", line 1936, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "<decorator-gen-70>", line 2, in show_company
File "./geetest_client.py", line 211, in captcha_counter_decorator
return func(*args, **kwargs)
File "./company/__init__.py", line 413, in show_company
count = db_data_count.find_one({'crn': company['crn']}) or {}
File "/srv/brm-api_staging/venv/lib/python3.8/site-packages/elasticapm/instrumentation/packages/base.py", line 210, in call_if_sampling
return self.call(module, method, wrapped, instance, args, kwargs)
File "/srv/brm-api_staging/venv/lib/python3.8/site-packages/elasticapm/instrumentation/packages/pymongo.py", line 75, in call
host, port = instance.database.client.address
TypeError: cannot unpack non-iterable NoneType object
Contributor
Author
There was a problem hiding this comment.
@messense thanks for the heads up! Do you connect to MongoDB with a unix domain socket instead of address/port? That could cause this issue. I'll see if we can work around that.
There was a problem hiding this comment.
We have also encountered this issue. (We do not connect to mongo with unix domain socket).
Contributor
Author
There was a problem hiding this comment.
@messense @QuantumGhost I opened #797 to try and address this. Would you mind giving this a quick spin in a dev/staging environment? You can install it like this:
pip install "https://github.com/beniwohli/apm-agent-python/archive/pymongo-address.zip#egg=elastic-apm==100
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
Implementation of span destination information as per elastic/apm#180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs elastic/apm#115