added support for global labels#549
Closed
beniwohli wants to merge 2 commits into
Closed
Conversation
axw
requested changes
Aug 6, 2019
axw
left a comment
axw
left a comment
Member
There was a problem hiding this comment.
A few little things, otherwise looks good.
| def __set__(self, instance, value): | ||
| if isinstance(value, compat.string_types): | ||
| items = (item.split(self.keyval_separator) for item in value.split(self.item_separator)) | ||
| value = {key: self.type(val) for key, val in items} |
Member
There was a problem hiding this comment.
I think we should strip key and val. Someone's bound to have white space in their environment variables.
| elif not isinstance(value, dict): | ||
| # TODO: better error handling | ||
| value = None | ||
| instance._values[self.dict_key] = value |
Member
There was a problem hiding this comment.
should probably check that the tag keys match TAG_RE here? also, truncate value to 1024 chars?
axw
approved these changes
Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #459