fixed a bug in the instrument config option#547
Closed
beniwohli wants to merge 1 commit into
Closed
Conversation
this happened during a rename a while ago. The attribute was renamed, but not the name in the `ConfigValue` constructor call. Ideally, `ConfigValue` would get the name from the attribute name, which should be possible by using a metaclass. Using metaclasses in a shared py2/py3 code base is somewhat cumbersome though, so let's wait with that until we drop support for Python 2. fixes elastic#546
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this happened during a rename a while ago. The attribute was renamed,
but not the name in the
ConfigValueconstructor call. Ideally,ConfigValuewould get the name from the attribute name, which shouldbe possible by using a metaclass. Using metaclasses in a shared py2/py3
code base is somewhat cumbersome though, so let's wait with that until
we drop support for Python 2.
fixes #546