Fix AttributeError in sync httpx instrumentation#1423
Merged
Conversation
github-actions
Bot
added
agent-python
community
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Contributor
|
Thank you for spotting and fixing this! |
Contributor
|
/test |
Contributor
|
/test |
beniwohli
pushed a commit
that referenced
this pull request
Dec 7, 2021
* Fix AttributeError in sync httpx instrumentation Closes 1422 * Link PR Co-authored-by: Colton Myers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
#1403 introduced a breaking change due to a refactor. This should make the sync code in line with the async version and fix the AttributeError.
Related issues
closes #1422