Skip to content

fix issue with multiple hosts/ports in psycopg2 connect span#1386

Merged
beniwohli merged 7 commits into
elastic:masterfrom
beniwohli:fix-1383
Nov 9, 2021
Merged

fix issue with multiple hosts/ports in psycopg2 connect span#1386
beniwohli merged 7 commits into
elastic:masterfrom
beniwohli:fix-1383

Conversation

@beniwohli

Copy link
Copy Markdown
Contributor

fixes #1383

@basepi basepi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions below.

Comment thread elasticapm/instrumentation/packages/psycopg2.py Outdated
Comment thread tests/fixtures.py
Comment thread tests/instrumentation/psycopg2_tests.py
@ghost

ghost commented Nov 8, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-09T13:32:49.843+0000

  • Duration: 32 min 55 sec

  • Commit: dabe37a

Test stats 🧪

Test Results
Failed 0
Passed 10219
Skipped 8977
Total 19196

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@beniwohli beniwohli merged commit 8deb2ef into elastic:master Nov 9, 2021
@beniwohli beniwohli deleted the fix-1383 branch November 9, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

APM crashes when postgres is configured with multiple hosts / ports in Django

3 participants