Pass custom client to aiohttp tracing middleware#1345
Merged
beniwohli merged 2 commits intoSep 29, 2021
Conversation
`elasticapm.contrib.aiohttp.ElasticAPM` allows an optional client instance as argument, though that client is not used in the tracing middleware. Instead it always uses the `base` modules client singleton. This change passes the client object to the tracing middleware allowing for a consistent use of a custom client object.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
beniwohli
approved these changes
Sep 29, 2021
beniwohli
left a comment
beniwohli
left a comment
Contributor
There was a problem hiding this comment.
Good catch, thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
elasticapm.contrib.aiohttp.ElasticAPMallows an optional clientinstance as argument, though that client is not used in the tracing
middleware. Instead, it always uses the
basemodules client singleton.This change passes the client object to the tracing middleware allowing
for a consistent use of a custom client object.
Related issues