Add aiomysql instrumentation#1107
Merged
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
beniwohli
approved these changes
Apr 29, 2021
beniwohli
left a comment
beniwohli
left a comment
Contributor
There was a problem hiding this comment.
This looks great, thanks! If you've got the time, could you add the context.destination data? If not, I'll add it before merging :)
Sparkycz
force-pushed
the
aiomysql-instrumentation
branch
from
3f43b35 to
856f4d6
Compare
Contributor
Author
|
I rebased the branch by the current master due to fix conflicts in register.py etc. |
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* Add aiomysql instrumentation * Add destination info to aiomysql instumentation * fix some isort linting issues and deprecation warnings Co-authored-by: Benjamin Wohlwend <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
closes #754