Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Adds initial CMake build support for the repository, allowing the C++98 and C++11 variants to be built as separate executables from a top-level CMake project.
Changes:
- Introduces a top-level
CMakeLists.txtthat builds bothC-11/andC-98/subprojects. - Adds per-variant CMake targets (
test_c11,test_c98) compilingtest.cppagainst the correspondingMemoryPool.h. - Updates the C++11 implementation to include
<cstdint>(intended to supportuintptr_tusage).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
CMakeLists.txt |
Adds a top-level CMake entry point that includes both language-standard subdirectories. |
C-11/CMakeLists.txt |
Defines a C++11 test executable and its include paths / flags. |
C-98/CMakeLists.txt |
Defines a C++98 test executable and its include paths / flags. |
C-11/MemoryPool.tcc |
Adds <cstdint> include related to pointer-sized integer usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,4 @@ | |||
| add_executable(test_c11 ../test.cpp) | |||
| target_include_directories(test_c11 PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_SOURCE_DIR}) | |||
| target_compile_options(test_c11 PRIVATE -O2) | |||
| @@ -0,0 +1,4 @@ | |||
| add_executable(test_c11 ../test.cpp) | |||
| target_include_directories(test_c11 PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_SOURCE_DIR}) | |||
| @@ -0,0 +1,4 @@ | |||
| add_executable(test_c98 ../test.cpp) | |||
| target_include_directories(test_c98 PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_SOURCE_DIR}) | |||
| target_compile_options(test_c98 PRIVATE -O2) | |||
| @@ -0,0 +1,4 @@ | |||
| add_executable(test_c98 ../test.cpp) | |||
| target_include_directories(test_c98 PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_SOURCE_DIR}) | |||
| #ifndef MEMORY_BLOCK_TCC | ||
| #define MEMORY_BLOCK_TCC | ||
|
|
||
| #include <cstdint> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by AI Agent