Skip to content

Add settings for auto pch#3184

Merged
bobbrow merged 9 commits into
masterfrom
mimatias/add_pch_settings
Feb 25, 2019
Merged

Add settings for auto pch#3184
bobbrow merged 9 commits into
masterfrom
mimatias/add_pch_settings

Conversation

@michelleangela
Copy link
Copy Markdown
Contributor

@michelleangela michelleangela commented Feb 16, 2019

Add these settings for auto pch:

  1. Cache path
  2. Cache size

grdowns
grdowns reviewed Feb 16, 2019
View reviewed changes
Comment thread Extension/package.json
sean-mcmanus
sean-mcmanus previously requested changes Feb 19, 2019
View reviewed changes
Comment thread Extension/package.json Outdated
"description": "Determines whether pop up notifications will be shown when a configuration provider extension is unable to provide a configuration for a source file.",
"scope": "resource"
},
"C_Cpp.intelliSense.cachePath": {
Copy link
Copy Markdown
Contributor

@sean-mcmanus sean-mcmanus Feb 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This naming style seems inconsistent with our existing settings like intelliSenseEngine, intelliSenseMode, and intelliSenseEngineFallback.

Copy link
Copy Markdown
Member

@bobbrow bobbrow Feb 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we were trying to be forward-looking, but I agree this might be premature.
We should rename these intelliSenseCachePath and intelliSenseCacheSize.

bobbrow
bobbrow requested changes Feb 22, 2019
View reviewed changes
Comment thread Extension/src/LanguageServer/client.ts Outdated
@bobbrow bobbrow dismissed sean-mcmanus’s stale review February 22, 2019 22:36

issue resolved in latest

@bobbrow bobbrow merged commit 361ca45 into master Feb 25, 2019
@bobbrow bobbrow deleted the mimatias/add_pch_settings branch February 25, 2019 22:51
@LinAGKar
Copy link
Copy Markdown

LinAGKar commented Mar 22, 2019

Does intelliSenseCachePath need to be unique per workspace, or can it be set to a global location? Really, on Linux it should point to somewhere in XDG_CACHE_HOME by default.

@bobbrow
Copy link
Copy Markdown
Member

bobbrow commented Mar 22, 2019

We were emulating Visual Studio which sets this per project, but you can certainly set C_Cpp.intelliSenseCachePath to a global location that all projects share.

@renkun-ken
Copy link
Copy Markdown

renkun-ken commented Mar 27, 2019

It looks like C_Cpp.intelliSenseCachePath currently does not translate environment variables like ${env:HOME} so that I can put these files somewhere into my home folder. I'm not sure if I'm missing something?

@sean-mcmanus
Copy link
Copy Markdown
Contributor

sean-mcmanus commented Mar 27, 2019

@renkun-ken It's a bug -- we have a fix at #3368 for our next release.

@renkun-ken
Copy link
Copy Markdown

renkun-ken commented Mar 27, 2019

Thanks, @sean-mcmanus!

@LinAGKar
Copy link
Copy Markdown

LinAGKar commented Mar 27, 2019 •
edited
Loading

~/.cache/vscode/ does not seem to work either. Also, the setting says that there is a fallback if an invalid path is given, but there is no indication whether the currently set path is considered valid.

@bobbrow
Copy link
Copy Markdown
Member

bobbrow commented Mar 28, 2019

@LinAGKar, it's the same bug as ${env:HOME} and will be fixed in the next release.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bobbrow bobbrow bobbrow approved these changes

@sean-mcmanus sean-mcmanus Awaiting requested review from sean-mcmanus

+1 more reviewer

@grdowns grdowns grdowns left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@michelleangela @LinAGKar @bobbrow @renkun-ken @sean-mcmanus @grdowns