Repository navigation
Clean up S3 fs and fix repr - #5
Open
jaysonsantos wants to merge 3 commits into
Open
jaysonsantos wants to merge 3 commits into
jaysonsantos wants to merge 3 commits into
Conversation
Signed-off-by: Jayson Reis <[email protected]>
Signed-off-by: Jayson Reis <[email protected]>
Signed-off-by: Jayson Reis <[email protected]>
andreoliwa
reviewed
Aug 23, 2018
| from fs_s3fs import S3FS | ||
|
|
||
|
|
||
| class EatFirstS3(S3FS): |
There was a problem hiding this comment.
So we only need this class for compatibility? It only changes the repr, right?
Contributor
Author
There was a problem hiding this comment.
Yes, because the original one didn't show much information
andreoliwa
approved these changes
Aug 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.