Repository navigation
Support orphaned resources cleanup for Nebius - #4412
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4401 for #3453. Nebius provisioning regularly leaks boot disks and pricing policies: the rollback in
create_instance()waits 25s for the instance to be deleted while deletion takes ~100s, and a pricing policy that is still being created can't be deleted.create_instance()call share a name withprovider_refencoded, and the disk and instance are also labeled withdstack_provider_refanddstack_provider_name, since Nebius drops labels on pricing policies.terminate_instance(): the instance first, then the boot disk and pricing policy, raisingNotYetTerminatedwhile a pricing policy is still being created instead of failing.UnboundLocalErrorin the provisioning rollback when the instance is already gone.nebiusamong the backends supporting orphan cleanup.