Repository navigation
Use sys.exit() instead of exit() in CLI - #4409
Merged
Merged
Conversation
exit() is added by the site module and is meant for the interactive shell. It is not defined under `python -S` or in some embedded interpreters, and it closes sys.stdin before raising SystemExit. Replace all exit() calls and hand-written `raise SystemExit(1)` with sys.exit(), and enable Ruff's PLR1722 to keep exit() from coming back. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI used the
exit()builtin, which thesitemodule adds for the interactive shell (docs). It isn't defined underpython -Sor in some embedded interpreters. It also closessys.stdinbefore raisingSystemExit.Changes:
exit()call (CLI,core/models/repos/remote.py,scripts/docs/) withsys.exit(). This was done with Ruff's autofix.raise SystemExit(1)inlogin.pyandconfirm_askwithsys.exit(1)for consistency. Theraise SystemExit(...)lines inpresets/workspace.pyare left as is: they're part of the generated wrapper scripts, not dstack code.PLR1722soexit()andquit()fail lint.Exit codes are unchanged. The only behavior difference is that exiting no longer closes
sys.stdin.🤖 Generated with Claude Code