Repository navigation
[CLI] Write logs, errors and warnings to stderr - #4405
Merged
Merged
Conversation
stdout should carry only command output so that `--json` stays parseable. Logging, fatal errors from `main()`, `warn()`, the update notice, `get` "not found" errors, and preset mirroring warnings now go to stderr. `error_console` resolves `sys.stderr` on each write. A plain `Console(stderr=True)` unwraps the proxy that `rich.live.Live` installs, so its output would garble an active spinner or live table. While `Live` is active, `error_console` also reports no fileno. Otherwise, on consoles without VT support, rich writes and flushes each styled segment separately, and the proxy prints each one on a separate line. Fixes: #4403 Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
un-def
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stdout should carry only command output so that
--jsonstays parseable. Logging, fatal errors frommain(),warn(), the update notice,get"not found" errors, and preset mirroring warnings now go to stderr.error_consoleresolvessys.stderron each write. A plainConsole(stderr=True)unwraps the proxy thatrich.live.Liveinstalls, so its output would garble an active spinner or live table. WhileLiveis active,error_consolealso reports no fileno. Otherwise, on consoles without VT support, rich writes and flushes each styled segment separately, and the proxy prints each one on a separate line.Fixes: #4403