Skip to content

Require nodes or ssh_config in fleet configurations #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r4victor merged 1 commit into from
Jul 29, 2024
Merged

Require nodes or ssh_config in fleet configurations #1464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/dstack/_internal/server/services/fleets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,8 @@ def _remove_fleet_spec_sensitive_info(spec: FleetSpec):
def _validate_fleet_spec(spec: FleetSpec):
if spec.configuration.name is not None:
validate_dstack_resource_name(spec.configuration.name)
if spec.configuration.ssh_config is None and spec.configuration.nodes is None:
raise ServerClientError("No ssh_config or nodes specified")
if spec.configuration.ssh_config is not None:
for host in spec.configuration.ssh_config.hosts:
if isinstance(host, str):
Expand Down