Skip to content

Consider removing .uwrap from things that cannot be really unwraped #452

Closed

Description

@sobolevn

We have a problem in our design: some classes do raise UnwrapFailedError when .unwrap() is called. And some not.

For example, ReaderResult will always return a function on .unwrap.
This is incosistent and even ugly.

I guess we should only allow unwrap on types that do raise.

Activity

  1. sobolevn commented on Jul 12, 2020

    @sobolevn
    MemberAuthor

    Done, see #446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions