Skip to content

Upload xunit performance results to benchview - #4

Merged
john-soklaski merged 7 commits into
masterfrom
benchview_upload
Sep 8, 2016
Merged

john-soklaski merged 7 commits into
masterfrom
benchview_upload

Conversation

@john-soklaski

Copy link
Copy Markdown
Collaborator

Load sas token from an environment variable
Store benchview generate files in their own folder
Use upload.py to upload results
Fix exception handler so it properly prints out error message

@dpodder

dpodder commented Sep 7, 2016

Copy link
Copy Markdown
Owner

@john-soklaski This looks great, thanks!

Just three small things before merging:

  • Could you trim trailing spaces in the file?
  • I think it would look better if we split the calls to all of the benchview tools into multi-line argument lists, like you did for submission.py and upload.py.
  • Could you squash this down before the merge to avoid the duplicate payload for PR Acqure benchview tools using nuget #2?

@john-soklaski

Copy link
Copy Markdown
Collaborator Author

@dpodder Thanks for the feedback. I've addressed all three points

@john-soklaski
john-soklaski merged commit f7729c7 into master Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants