Repository navigation
Upload xunit performance results to benchview - #4
Merged
Merged
Conversation
Owner
|
@john-soklaski This looks great, thanks! Just three small things before merging:
|
john-soklaski
force-pushed
the
benchview_upload
branch
from
September 7, 2016 17:55
2f11941 to
e1781cc
Compare
Collaborator
Author
|
@dpodder Thanks for the feedback. I've addressed all three points |
john-soklaski
force-pushed
the
benchview_upload
branch
from
September 7, 2016 19:27
a8890f9 to
879ac9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load sas token from an environment variable
Store benchview generate files in their own folder
Use upload.py to upload results
Fix exception handler so it properly prints out error message