Skip to content

Bugfix/#79 negative time calculation - #80

Closed
Death111 wants to merge 2 commits into
developfrom
bugfix/#79_negativeTimeCalculation
Closed

Death111 wants to merge 2 commits into
developfrom
bugfix/#79_negativeTimeCalculation

Conversation

@Death111

@Death111 Death111 commented Mar 21, 2021 •

Copy link
Copy Markdown
Collaborator

Fixes issue where time was calculated wrong in report for the whole project, when work items exist which have startTime after endTime.
Issue was in Controller.calcSeconds but I also adapted logic at the other places

…time

* time calculation was wrong, as it did not consider negative time frames (startTime after endTime)
* using same logic now like for work time calculation
@Death111 Death111 self-assigned this Mar 21, 2021
@Death111
Death111 requested a review from mplieske March 21, 2021 22:46
@Death111
Death111 requested a review from JSchraff April 1, 2021 13:03
@Death111

Death111 commented Apr 1, 2021

Copy link
Copy Markdown
Collaborator Author

Maybe it would be more obvious for the user when the negative time is shown in the work items. If this is done have a look at the report timeline, as this will most likely not work with negative times.

Instead of hiding the wrong start end time selection by just using the abs() method (like it was fixed now).

@JSchraff JSchraff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Death111 Death111 closed this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants