Improve perf of ProcessInternal by ~ 4%

Austin Harris · Austin Harris · commit 4b08ea9afa62 · 2015-01-30T15:38:55.000-07:00
diff --git a/Json-Rpc/JsonRpcProcessor.cs b/Json-Rpc/JsonRpcProcessor.cs
@@ -114,11 +114,14 @@ private static string ProcessInternal(string sessionId, string jsonRpc, object j
                     }
                 }
 
-                var responses = batch.Select(tuple => tuple.Item2)
-                    .Where(resp => resp.Id != null || resp.Error != null)
-                    .Select(Newtonsoft.Json.JsonConvert.SerializeObject).ToArray();
+                var responses = new string[batch.Count(x=>x.Item2.Id!=null || x.Item2.Error != null)];
+                var idx = 0;
+                foreach (var resp in batch.Where(x => x.Item2.Id != null || x.Item2.Error != null))
+                {
+                    responses[idx++] = JsonConvert.SerializeObject(resp.Item2);
+                }
 
-                return responses.Count() > 1 ? string.Format("[{0}]", string.Join(",", responses)) : responses.First();
+                return responses.Length == 1 ? responses[0] : string.Format("[{0}]", string.Join(",", responses));
             }
             catch (Exception ex)
             {

Original file line number	Diff line number	Diff line change
`@@ -114,11 +114,14 @@ private static string ProcessInternal(string sessionId, string jsonRpc, object j`
`114`	`114`	`}`
`115`	`115`	`}`
`116`	`116`
`117`		`- var responses = batch.Select(tuple => tuple.Item2)`
`118`		`- .Where(resp => resp.Id != null \|\| resp.Error != null)`
`119`		`- .Select(Newtonsoft.Json.JsonConvert.SerializeObject).ToArray();`
	`117`	`+ var responses = new string[batch.Count(x=>x.Item2.Id!=null \|\| x.Item2.Error != null)];`
	`118`	`+ var idx = 0;`
	`119`	`+ foreach (var resp in batch.Where(x => x.Item2.Id != null \|\| x.Item2.Error != null))`
	`120`	`+ {`
	`121`	`+ responses[idx++] = JsonConvert.SerializeObject(resp.Item2);`
	`122`	`+ }`
`120`	`123`
`121`		`- return responses.Count() > 1 ? string.Format("[{0}]", string.Join(",", responses)) : responses.First();`
	`124`	`+ return responses.Length == 1 ? responses[0] : string.Format("[{0}]", string.Join(",", responses));`
`122`	`125`	`}`
`123`	`126`	`catch (Exception ex)`
`124`	`127`	`{`