Skip to content

Merge master to feature/tasks#7823

Closed
dotnet-bot wants to merge 43 commits into
feature/tasksfrom
merges/master-to-feature/tasks
Closed

Merge master to feature/tasks#7823
dotnet-bot wants to merge 43 commits into
feature/tasksfrom
merges/master-to-feature/tasks

Conversation

@dotnet-bot

Copy link
Copy Markdown
Contributor

This is an automatically generated pull request from master into feature/tasks.

git fetch --all
git checkout merges/master-to-feature/tasks
git reset --hard upstream/feature/tasks
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-feature/tasks --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

auduchinok and others added 30 commits September 27, 2019 23:41
* Fix some issues in ValueNone implementation

* More debug display

* Some for options in debug display

* Apply suggestions from code review

Co-Authored-By: Eugene Auduchinok <[email protected]>

* Probably better stringing

* Add them baselines

* Add sprintfn tests

* Update OptionModule.fs
* Optimize Seq.Last like Seq.Length

Add type check to Seq.Last and Seq.TryLast to avoid full iteration if not necessary. Like Seq.Length does it at
https://github.com/dotnet/fsharp/blob/c18e1780b3f3f345364cb1ad8e510ea9f4590d3a/src/fsharp/FSharp.Core/seq.fs#L709

* Add test for Optimized Seq.Last and Seq.TryLast

* style update

* style update 2

* update comments and fix build error

Github Build error was:
 Check failure on line 132 in tests\FSharp.Core.UnitTests\FSharp.Core\Microsoft.FSharp.Collections\SeqModule2.fs

@azure-pipelines
azure-pipelines
/ fsharp-ci (Build Windows vs_release)

tests\FSharp.Core.UnitTests\FSharp.Core\Microsoft.FSharp.Collections\SeqModule2.fs#L132
tests\FSharp.Core.UnitTests\FSharp.Core\Microsoft.FSharp.Collections\SeqModule2.fs(132,58): error FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'a has been constrained to be type 'unit'.

* include List.last case

* include list in tests

* ensure same exception is raised on empty list

* typo

* Added implementation of List.last since it is not available at this point due to compilation error

The recursive function could also be defined inside but i guess then it would be reallocated on every call to Seq.Last (in case of list match).
An alternative would be to add .Last member on list type (like .Length member)

* inline List.last

reverting my previous attempt  b329e23
tail rec functions should be inlined

* typo in tests(build failed)

* typo2 in test (Build failed)

* move implemnetation to internal module

as suggested by dsyme

* renamed internal tryLast to tryLastV
* Fix member declaration ranges

* Fix member declaration ranges

* Update baseline

* Update baseline
…table (#7682)

* Recover ValNoMutable and PropertyCannotBeSet errors

* Recover FieldNotMutable error

* Refactor tests

* Refactor tests

* Update baseline
* TailCalls test migration

* fix the diff in IL

* fix for netcore
* Delete duplicate test

StartTask was exactly the same as CreateTask 50 lines above.

* Restore poorly merged test case
* init a basic readme.md for fsharp test suite

* fix title and try to add link

* case sensitive?

* Update layout.

* Update readme.md
TIHan and others added 13 commits October 31, 2019 18:18
* Update dependencies from https://github.com/dotnet/arcade build 20191004.2

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19504.2

* Update dependencies from https://github.com/dotnet/arcade build 20191005.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19505.1

* Update dependencies from https://github.com/dotnet/arcade build 20191006.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19506.1

* Update dependencies from https://github.com/dotnet/arcade build 20191009.5

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19509.5

* Update dependencies from https://github.com/dotnet/arcade build 20191010.4

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19510.4

* Update dependencies from https://github.com/dotnet/arcade build 20191011.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19511.1

* Update dependencies from https://github.com/dotnet/arcade build 20191015.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19515.1

* Update dependencies from https://github.com/dotnet/arcade build 20191015.2

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19515.2

* Update dependencies from https://github.com/dotnet/arcade build 20191017.8

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19517.8

* Update dependencies from https://github.com/dotnet/arcade build 20191018.2

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19518.2

* Update dependencies from https://github.com/dotnet/arcade build 20191021.4

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19521.4

* Update dependencies from https://github.com/dotnet/arcade build 20191022.8

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19522.8

* Update dependencies from https://github.com/dotnet/arcade build 20191023.3

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19523.3

* Update dependencies from https://github.com/dotnet/arcade build 20191024.2

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19524.2

* Update dependencies from https://github.com/dotnet/arcade build 20191025.2

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19525.2

* Update dependencies from https://github.com/dotnet/arcade build 20191026.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19526.1

* Update dependencies from https://github.com/dotnet/arcade build 20191027.3

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19527.3

* Update dependencies from https://github.com/dotnet/arcade build 20191028.5

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19528.5

* Update dependencies from https://github.com/dotnet/arcade build 20191029.9

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19529.9

* Update dependencies from https://github.com/dotnet/arcade build 20191030.15

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19530.15

* Update dependencies from https://github.com/dotnet/arcade build 20191031.14

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19531.14

* Update dependencies from https://github.com/dotnet/arcade build 20191101.3

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19551.3

* Update dependencies from https://github.com/dotnet/arcade build 20191102.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19552.1

* Update dependencies from https://github.com/dotnet/arcade build 20191104.3

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19554.3

* work around dotnet/wpf#1718 by not embedding untracked sources

* use arcade mechanism of populating package icons
…105.7

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19555.7
FreeVars cache optimization on Expr.Let
…28f-7727ed23bc03

[master] Update dependencies from dotnet/arcade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants