Fix member declaration ranges#7676
Conversation
|
Needs baseline update. |
|
@brettfo I've noticed the macOS FCS build is green despite it clearly needs a baseline update. It seems tests do not run on Linux and macOS, do they? |
|
Is the Linux failure expected? The native crash report looks odd. |
|
Restarting it (since it seems to generally be fine after a restart). |
|
It seems all recent PRs fail this way currently, so I don't think restarting it will actually help. |
|
Yep, doesn't look like some transient failure then :( |
|
For anyone following along at home, the Linux_FCS failures are unrelated and recently disabled via #7697. |
auduchinok
force-pushed
the
memberRanges
branch
from
2309556 to
95ed7b6
Compare
|
This is ready. |
|
Is there an issue listed somewhere that this resolves? |
|
Probably not. I've updated the PR description. |
|
@auduchinok Thanks, that's good to know. |
|
@TIHan can we get a review on this puppy? Although it doesn't fix a tooling bug on our end, it does fix a future one we'd have if we did a similar kind of thing in VS as described above |
|
Yes, I will try to get a review today. |
|
Any news on it? |
* Fix member declaration ranges * Fix member declaration ranges * Update baseline * Update baseline
6 participants
Currently member declarations have their beginnings stripped, e.g.
static memberis not in the reported range, nor are attributes. This PR fixes these ranges.AST viewer example: jindraivanek.gitlab.io.