👍 though I don't think this will make it for VS 2015 😭

I can confirm:

Ok, passed 100 tests.

@latkin so we will have a function with a major bug in VS 2015 release? It's nonsense.

Fully agree with @vasily-kirichenko, it makes no sense to publish an absolutely new function which is known to be buggy to the wild. If we can't make it correct, maybe it's better to remove it?

at first i thought this is only a very strange edge case that nobody will ever notice, but then again chunkBySize is a function that people will use to distrubute workloads on different nodes.
If we release the current Array.chunkBySize we will see all kinds of strange NRE and data loss in the wild.

The complete list of cases failing for chunkSize <= 10 is:

chunkSize: [| array lengths |]
3: [|4|]
4: [|6; 9|]
5: [|6; 8; 12; 16|]
6: [|8; 10; 15; 20; 25|]
7: [|8; 10; 12; 15; 18; 24; 30; 36|]
8: [|10; 12; 14; 18; 21; 28; 35; 42; 49|]
9: [|10; 12; 14; 16; 21; 24; 28; 32; 40; 48; 56; 64|]
10: [|12; 14; 16; 18; 21; 24; 27; 32; 36; 45; 54; 63; 72; 81|]

I think I agree with the idea that if this cannot be fixed for 4.0, then it should be dropped altogether.

The pattern of bad cases (black dots) vs good cases (green dots) is actually kind of interesting. The blue line is chunkSize = sqrt arrayLength

When you think that you are dealing with a small bug:

Luckily, I was too pessimistic in my estimate of the approval bar. This was just in time to still get a 👍 from shiproom.

Yay.
On Jun 19, 2015 21:07, "Lincoln Atkinson" [email protected] wrote:

Luckily, I was too pessimistic in my estimate of the approval bar. This
was just in time to still get a [image: 👍] from shiproom.

—
Reply to this email directly or view it on GitHub
#503 (comment)
.

Btw I now have nearly 100 property based tests (makes 10000 tests) and didn't spot a second bug yet.

Greate news.

@forki good to hear, and thanks again for the timely discovery

Yes indeed, thanks @forki for the property test goodness! And thanks @latkin for the superb expectation management :D

Great to see this fixed in time!