Bug fix to allow RebuildShapeCombination for indexed static property gets#2512
Conversation
|
@alan-geller, |
|
@alan-geller could you add a regression test case so that we can keep this working? Thanks Kevin |
|
would it make it easier to diagnostic issues in this code if https://github.com/Microsoft/visualfsharp/pull/2512/files#diff-68af4b41d78e9577b6a461499c202298R2201 | _ -> raise <| System.InvalidOperationException (SR.GetString(SR.QillFormedAppOrLet))was also printing |
|
Should we format that whole pattern match which is a bit difficult to comprehend due to misalignment? |
|
The fix is correct, just needs the regression test |
|
I pushed a unit test. I think it's correct and in the right place, although it's a bit hard to be sure. |
|
@alan-geller That's great, thanks, I will take care of the hand-waving to make sure the test is situated well. Kevin |
|
Thanks, @KevinRansom ! |
|
@dotnet-bot test this please |
|
Thank you for this |
5 participants
The current implementation of RebuildShapeCombination fails if there are parameters passed to a StaticPropGetOp. The match pattern requires the arguments to be an empty list, even though the code for that match doesn't require this, and indeed mkStaticPropertyGet explicitly supports indexed properties and non-empty args lists.
All that is required is to replace the [] in the match with _, so that any list (whether empty or not) will match.