Support nocopy option in volume binds (#688)#696
Closed
dmandalidis wants to merge 1 commit intodocker-java:masterfrom
dmandalidis:issue-688
Closed
Support nocopy option in volume binds (#688)#696dmandalidis wants to merge 1 commit intodocker-java:masterfrom dmandalidis:issue-688
dmandalidis wants to merge 1 commit intodocker-java:masterfrom
dmandalidis:issue-688
Conversation
|
|
||
| private AccessMode accessMode; | ||
|
|
||
| private boolean noCopy; |
Contributor
There was a problem hiding this comment.
please use Boolean here
Member
|
Please annotate field with |
Author
|
...I think that the pr build is failing independently of this pr |
Member
|
@dmandalidis is it possible to make some integration test? |
Author
|
@KostyaSha done |
KostyaSha
reviewed
Sep 29, 2016
|
|
||
| @Test | ||
| public void createContainerWithVolumesFrom() throws DockerException { | ||
|
|
Member
There was a problem hiding this comment.
Please remove this whitespaces.
Member
|
Oh, this vs #705 Could you review each other PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is